AO3-5244 Refactor select_all.js#5714
Open
ScottVenkataraman wants to merge 3 commits into
Open
Conversation
sarken
requested changes
May 22, 2026
Collaborator
sarken
left a comment
sarken
left a comment
There was a problem hiding this comment.
Thanks for working on this! It looks good, but would you be willing to rewrite it to use vanilla JavaScript instead of jQuery? We're trying to reduce our reliance on jQuery and making the switch now means we'd only need to test these checkboxes once, instead of once for a refactor and once for a vanilla JavaScript rewrite.
github-actions
Bot
added
Coder Has Actioned Review
and removed
Reviewed: Action Needed
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-5244
Purpose
What does this PR do?
Refactors the select_all js file to remove repetitive code and improve flexibility.
Testing Instructions
There should be no change in functionality, and no new tests needed.
Credit
What name and pronouns should we use to credit you in the Archive of Our Own's Release Notes?
Scott Venkataraman he/him